moltar / typescript-runtime-type-benchmarks

📊 Benchmark Comparison of Packages with Runtime Validation and TypeScript Support
https://moltar.github.io/typescript-runtime-type-benchmarks/
637 stars 62 forks source link

Add Deepkit #1199

Closed M-jerez closed 8 months ago

M-jerez commented 8 months ago

Hi @moltar, First of all thanks for this repo, I'm sure is becoming a reference with everything validation related in JS/Typescript! 👍

This PR adds the Deepkit validation library @deepkit/types to the benchmarks. https://deepkit.io/

Any questions or amendments please let me know!

We should also close #895

moltar commented 8 months ago

Also, please run a linter npm run lint. Thanks!

M-jerez commented 8 months ago

@moltar all fixes applied, linting and testing passing in local. I also did review the test so it better reflect deepkit's capabilities.

Think everything should be ready to go 👍

M-jerez commented 8 months ago

@moltar quick question about these conflicts with the test results docs/results/node-20.json. Should I remove my changes so there are no more conflicts (I guess there is an action to run the benchmark in this case) or should i keep overriding the result from main with mine to include the deepkit results?

moltar commented 8 months ago

@moltar quick question about these conflicts with the test results docs/results/node-20.json. Should I remove my changes so there are no more conflicts (I guess there is an action to run the benchmark in this case) or should i keep overriding the result from main with mine to include the deepkit results?

Hey, yes, the tests will be auto-generated by CI, so it is safe to remove the file and that would fix the conflict.