search

moltar / typescript-runtime-type-benchmarks

📊 Benchmark Comparison of Packages with Runtime Validation and TypeScript Support
https://moltar.github.io/typescript-runtime-type-benchmarks/
637 stars 62 forks source link

isolate benchmarked module dependencies #1219

Open hoeck opened 6 months ago

hoeck commented 6 months ago

Having all tested modules share the same node_modules namespace seems to introduce new issues / limits:

  1. dependabot upgrades of Typescript seems to be unreliable: https://github.com/moltar/typescript-runtime-type-benchmarks/pull/1218#issuecomment-1987252101
  2. all modules must share the same Typescript version

The first issue may just be a nuisance, requiring more maintenance work.

The second one though may be more severe, in the worst case requiring us to drop old modules or to wait until all modules are able to use new TS versions.

In #864 we already moved to running each benchmark in its own process. Might be just the next logical step to also isolate node_modules? That also helps isolating the different build / code generation steps required for some modules.

@moltar any feedback?

moltar commented 6 months ago

Yes, 100% the issue is there and needs to be fixed.

I wanted to re-design the entire project setup entirely, including this problem if isolation and the umbrella issue is #899, albeit it does not have the meat on that bone there, regarding the details.

I will link to this issue from there for documentation.