moltar / typescript-runtime-type-benchmarks

📊 Benchmark Comparison of Packages with Runtime Validation and TypeScript Support
https://moltar.github.io/typescript-runtime-type-benchmarks/
637 stars 62 forks source link

introduce @effect/schema #1241

Closed KhraksMamtsov closed 4 months ago

moltar commented 4 months ago

screenshot-20240527T145638-TMrKagW5@2x

Do we need the result const?

KhraksMamtsov commented 4 months ago

Nope

KhraksMamtsov commented 4 months ago

But otherwise it shows an error

Assertions require every name in the call target to be declared with an explicit type annotation.ts(2775)

effect-schema.ts(67, 9): 'asserts' needs an explicit type annotation.
moltar commented 4 months ago

But otherwise it shows an error

Assertions require every name in the call target to be declared with an explicit type annotation.ts(2775)

effect-schema.ts(67, 9): 'asserts' needs an explicit type annotation.

Where do you seed that?

PR build seems to pass.

KhraksMamtsov commented 4 months ago

I fixed this warning) when can I expect a merge?

moltar commented 4 months ago

I was waiting for @hoeck to review. But maybe he's busy. I'll merge for now.

@hoeck Please do a reverse review when/if you have time.

KhraksMamtsov commented 4 months ago

Thank you

hoeck commented 4 months ago

@moltar had already a look at it and was waiting for the explanation for the warning that got fixed.

Looks all good to me :+1:

Thanks @KhraksMamtsov