moltar / typescript-runtime-type-benchmarks

📊 Benchmark Comparison of Packages with Runtime Validation and TypeScript Support
https://moltar.github.io/typescript-runtime-type-benchmarks/
621 stars 59 forks source link

Update rescript-schema up to V8 #1271

Closed DZakh closed 1 month ago

DZakh commented 1 month ago

@hoeck I'm interested in seeing the performance changes for v8. Could you merge the PR, please? 👀

hoeck commented 1 month ago

@DZakh thanks for pinging me, the mail from github somehow slipped off my radar :sweat_smile: sorry

DZakh commented 1 month ago

Btw, node v22 runner did break https://github.com/moltar/typescript-runtime-type-benchmarks/actions/runs/10008222868/job/27664468375

hoeck commented 1 month ago

Btw, node v22 runner did break https://github.com/moltar/typescript-runtime-type-benchmarks/actions/runs/10008222868/job/27664468375

Yeah noticed this too, the npm install prior to running the linter failed with an NPM internal error. Works on my machine though so let's just run it again and hope for the best.

hoeck commented 1 month ago

Ok, this seems to be a bug in the latest NPM version used by nodejs 22: https://github.com/npm/cli/issues/7672

If I am reading this right, waiting for https://github.com/actions/node-versions/pull/182 should give us a fixed node/npm version the next time we run the action (maybe delete the action cache before, don't know).

hoeck commented 1 month ago

Now it went through.