Calling Moltin.Products.UpdateRelationships(moltinId, 'category', []) fails

[aravindanve]

Hi!

Calling await Moltin.Products.UpdateRelationships(moltinId, 'category', []) to clear all Product <=> Category relationships fails with the following error:

{
    "message": {
        "errors": [
            {
                "status": 500,
                "title": "Internal Server Error",
                "detail": "There was an internal server error, you can report with your request id.",
                "request_id": "6c8b4050dc4c0eb2"
            }
        ]
    }
}

Although a PUT request directly placed to the endpoint works.

Take a look at the code here on Line: 8

https://github.com/moltin/js-sdk/blob/6ebcb9985221a3dfc11fdf2b4ed6bae963167594/src/utils/helpers.js#L4-L16

All other return statements return an Array whereas, this line returns a string. Which I suppose is again converted to JSON string with JSON.stringify(body) resulting in "[]" instead of []

[ynnoj]

@aravindanve Are you able to share the full request payload built from the library?

[ynnoj]

If you're trying to remove all existing relationships, then UpdateRelationships would be the right method to use.

Moltin.Products.UpdateRelationships(id, 'category')

I suspect the 500 you're seeing is because you're using CreateRelationships with an empty payload. Let me know if this helps 🙃

[aravindanve]

Hi @ynnoj

Sorry, my mistake. I meant Moltin.Products.UpdateRelationships(id, 'category'). I've updated the issue.

[ynnoj]

@aravindanve Can you share the payload in the request body please?

[aravindanve]

I'm using it in the backend. I need to do a quick browser test to get the request payload from the sdk. Hold on.

[aravindanve]

@ynnoj here you go! (https://runkit.com/aravindanve/moltin1)

Screenshot here: (https://pasteboard.co/GJi8oWo.png)

[ynnoj]

Looks like your hypothesis is correct! 😄

[aravindanve]

Hi @ynnoj, any idea on when this will be merged?

[ynnoj]

Hey @aravindanve. Will be merged and published this morning.

[ynnoj]

2.6.2 just published with this fix 🎉

[aravindanve]

@ynnoj Perfect! Thank You!