moltin / js-sdk

JavaScript & Node.js SDKs for the Elastic Path Commerce Cloud eCommerce API
http://documentation.elasticpath.com/
MIT License
173 stars 77 forks source link

Missing `target_attributes` field for promotions `schema` type #777

Closed samblissard closed 1 year ago

samblissard commented 1 year ago

The schema object contains a field called target_attributes which should define the conditions that a promotion is applied to a cart: https://documentation.elasticpath.com/commerce-cloud/docs/api/promotions/create-item-percent-discount-promotion.html#the-schema-object

This field is absent from the promotion schema types: https://github.com/moltin/js-sdk/blob/main/src/types/promotions.d.ts#L120-L125 Can this be added?

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 20.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: