Changed moltin/cart package version

nethask commented 7 years ago

Continuation of the problem https://github.com/moltin/cart/pull/32

I've changed the commit "Adding composer.json" where I point the package version of moltin/cart from dev-master to 1.0.0.

For those who stayed on PHP 5.4 there is a problem with deploying which is best described by composer

""" Problem 1

moltin/cart dev-master requires moltin/currency 1.1.0 -> satisfiable by moltin/currency[1.1.0] but these conflict with your requirements or minimum-stability.
moltin/laravel-cart v4.2 requires moltin/cart dev-master -> satisfiable by moltin/cart[dev-master].
Installation request for moltin/laravel-cart v4.2 -> satisfiable by moltin/laravel-cart[v4.2]. """

If there will be problems with merging this request I'm ready to help you with git rebase. Thanks!

zot24 commented 7 years ago

Could you please rebase this branch onto master and make it just one clean commit? that will help, thanks.

nethask commented 7 years ago

@zot24 What do you mean by one clean commit? If I will add a commit on top of a HEAD in this project - that will not help to solve the problem for those who are using v4.2.

zot24 commented 7 years ago

Oh! I see you have forked from 4.2 👍

I'm afraid @nethask we can't validate this PR and we are gonna start changing the status of some libraries as deprecated so if it's ok with you I might change the README file to make this clear and point people that could be hitting this problem to your fork.

Thanks and sorry for the inconvenient

moltin / laravel-cart

Changed moltin/cart package version #65