search

moltin / python-sdk

Moltin python SDK
MIT License
6 stars 9 forks source link

is there a proper way to manage the Moltin Flows ? #5

Open neywen opened 8 years ago

neywen commented 8 years ago

I did not see any Flow or Entry endPoint in the main moltin.py file.

In order to retrieve an entry from one of my custom Flow, I had to write :

my_entry = m.request.get(myFlowUrl, {myParam: value})

It works, but I supposed it's to be considered hacky. Is there any proper way to do that (<=> using a find_by method for a Flow entry) ?

Thanks, l.

neywen commented 8 years ago

unfortunately, I just understood, using my unitary tests, that

m.request.get(myFlowUrl, {myParam: value})

does not take the payload parameter in consideration. It returns all the values from the Flow, and does not filter the results as expected.

neywen commented 8 years ago

I sent a PR to fixed the bug for the 'get' request : https://github.com/moltin/python-sdk/pull/7.

I'll try and implement what it needs to mange the Flows

neywen commented 8 years ago

sent a new PR, with a new 'Entry' endpoint : https://github.com/moltin/python-sdk/pull/8