search

mom-ocean / MOM5

The Modular Ocean Model
https://mom-ocean.github.io/
GNU Lesser General Public License v3.0
82 stars 95 forks source link

Set default date in access-om driver #347

Closed aidanheerdegen closed 3 years ago

aidanheerdegen commented 3 years ago

Closes #340

The original fix for #340 introduced an error for the ACCESS-OM driver due to the way the driver initialises the date.

This is a pretty hacky fix, all the logic for setting the dates is very convoluted, and state dependent, but I don't want to change too much in case it breaks something.

aidanheerdegen commented 3 years ago

I haven't tested this yet, so please don't merge.

aekiss commented 3 years ago

Thanks @aidanheerdegen I've built an executable /g/data/v45/aek156/access-om2-build/access-om2/bin/fms_ACCESS-OM-BGC_bd31ea8_libaccessom2_0ab7295.x and I'm testing it out now

aekiss commented 3 years ago

cold-start run completed ok /g/data/v45/aek156/access-om2-build/1deg_jra55_iaf_bgc_test

now I'll try continuing it

aekiss commented 3 years ago

That also ran fine, so I'm happy to merge this if you are. Thanks for the quick turnaround.

aekiss commented 3 years ago

would this issue affect any other drivers?

aidanheerdegen commented 3 years ago

I don't think so. It was because of the accessom2 logic Nic bolted on to the existing driver. It made sense to initialise to date_init because that was the one that was used.

As I said, the logic is horrible and could do with being cleaned up, but it works so I think best just to leave it.