search

mom-ocean / MOM5

The Modular Ocean Model
https://mom-ocean.github.io/
GNU Lesser General Public License v3.0
82 stars 95 forks source link

Fix issues with unitialised variables #350

Closed russfiedler closed 2 years ago

russfiedler commented 2 years ago

Addresses issues here. https://github.com/mom-ocean/MOM5/issues/349

aekiss commented 2 years ago

@russfiedler this looks good to me - should I merge?

aidanheerdegen commented 2 years ago

The fms stuff should be fixed in the FMS repo

aidanheerdegen commented 2 years ago

Specifically the changes under shared. Sorry I don't make the rules .

aidanheerdegen commented 2 years ago

~@russfiedler can you rebase this on master as that fixes the FMS stuff. If not I can take a crack at it.~

Scratch that. Turns out I didn't actually fix them, as they didn't get flagged in the FMS only build. Odd.

Have made an FMS issue (https://github.com/mom-ocean/FMS/issues/7), will fix and include in this PR if that is ok

aidanheerdegen commented 2 years ago

Now I'm confused, as I did fix that. Sorry for the spam, I'll take another look and report back.

aidanheerdegen commented 2 years ago

Ok, rebased on top of the FMS update which actually did fix the clock id variable initialisation and pushed to the PR branch. Hope that is ok @russfiedler.

aidanheerdegen commented 2 years ago

Okey-doke, this PR no longer touches FMS, so should be fine to merge.