search

mom-ocean / MOM5

The Modular Ocean Model
https://mom-ocean.github.io/
GNU Lesser General Public License v3.0
82 stars 95 forks source link

unmask dxt, dxu, dyt, dyu, dxtn, dyte output #376

Open aekiss opened 1 year ago

aekiss commented 1 year ago

closes https://github.com/mom-ocean/MOM5/issues/375

russfiedler commented 1 year ago

@aekiss I've had a think about this and I don't think I can endorse this as it stands. It's a change specifically introduced for the benefit of a particular piece of post processing software and you would have to prove that it's not going to break somebody else's software that relies on the current version. Its' a bad habit to get into. I suggest making it a conditional compile for ACCESS or ACCESS-OM only.

aekiss commented 1 year ago

OK that's fair enough, I wasn't thinking of the bigger picture. It's hard to imagine anybody needing land masking in these grid fields, but I take your point. I won't bother with conditional compilation - people can use this branch from my fork if they ever need this.