search

moment / luxon

⏱ A library for working with dates and times in JS
https://moment.github.io/luxon
MIT License
15.4k stars 729 forks source link

Correctly handle hourCycle when expanding macro tokens #1391

Closed diesieben07 closed 1 year ago

diesieben07 commented 1 year ago

When expanding macro tokens, we must expand "hour" either into "h" or "H", depending on the desired hour cycle. This fixes #1197.

I have not changed the parsing of h, which currently accepts 24 hours just the same as H. This would be a breaking change and I am not sure it is worth introducing another special case in the parser for this.

flaviendelangle commented 1 year ago

Hi,

Thanks again for your work ! Do you have a time estimate for the release ?