Fix DateTime#diff for cross-zone diffs by checking where dayDiff is off by 2 days (#1165)

moment / luxon

⏱ A library for working with dates and times in JS

https://moment.github.io/luxon

MIT License

15.26k stars 731 forks source link

Closed ConnorLanglois closed 1 year ago

ConnorLanglois commented 1 year ago

Fixes #1165 (I think). Please review code and see if correct; I am not a datetime expert and this date stuff can be hard.

linux-foundation-easycla[bot] commented 1 year ago

:x: - login: @ConnorLanglois / name: Connor Langlois . The commit (6c6425a023be1f92053981aca524bac8ab7ad4c9) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

diesieben07 commented 1 year ago

Thank you for your contribution, I have merged a solution based on your code and your test manually.