`refrenceDate` support for `fromObject`

moment / luxon

⏱ A library for working with dates and times in JS

https://moment.github.io/luxon

MIT License

15.05k stars 730 forks source link

`refrenceDate` support for `fromObject` #1632

Open angelaki opened 1 month ago

angelaki commented 1 month ago

Analogous to date-fns's parse method, luxon should support a referenceDate, too.

linux-foundation-easycla[bot] commented 1 month ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: angelaki / name: Tristan (886c8014b34b2e3f3373d3200ae370ebfe3d862f, c459f393990c9bac4c2ee073437462de793944cc, 8e568e68c5131900d0ae432f53f8fed0fd9002b5, b655ae7f0d3720429adff0a46b2f70ef5b3185d9, 448be0e3663baf2906641232cc13e7562289c333)

dasa commented 1 month ago

refrenceDate -> referenceDate

angelaki commented 1 month ago

So what are we waiting for? :)

dasa commented 1 month ago

I'm not sure about the logic, but there is a spelling typo I mentioned at: https://github.com/moment/luxon/pull/1632#issuecomment-2118162985

angelaki commented 1 month ago

Fixed your concerns. Thank you pretty much. Time for a merge now? @Luxon-Team?

diesieben07 commented 1 month ago

I'll do another review pass this evening!

angelaki commented 3 weeks ago

@diesieben07 did this evening already happen? ;) Sorry for bumping, no hurries! Just kidding :) Just wanted to create a PR for a twoDigitCutoffYear parameter (for Settings being just used as fallback) but used my master branch for this fix. So it's kinda unhandy to create a new PR. My fault ...

Btw: needs @types/luxon be adopted, too? Or do these libraries get generated?

diesieben07 commented 1 week ago

Just wanted to create a PR for a twoDigitCutoffYear parameter (for Settings being just used as fallback) but used my master branch for this fix. So it's kinda unhandy to create a new PR. My fault ...

You can still create a new branch in your repo that tracks Luxon's master branch, they don't have to be named the same.