search

moment / moment-timezone

Timezone support for moment.js
momentjs.com/timezone
MIT License
3.82k stars 835 forks source link

data: Add 2024a #1093

Closed tmkx closed 7 months ago

tmkx commented 7 months ago

close #1091 close #1092

Flightfreak commented 7 months ago

Thx @tmkx! Out of interest, is there a described procedure or automated script to incorporate IANA changes?

tmkx commented 7 months ago

Yes, you can execute

npx grunt data
npx grunt build

to update it :)

gilmoreorless commented 7 months ago

Quick note here: Contributor PRs to update the data are generally not accepted as-is. The wild variances in tooling on different machines have caused several bugs in past data updates. This isn't a judgement on the contributors, just a reflection of hidden subtle incompatibilities in underlying systems. It's hard to verify a data change we haven't built ourselves. (Case in point, this PR contains some automated test fixes that are completely unrelated to the tzdb data, and just a quirk of it being the first build of 2024.)

Over the last few weeks I've worked on a fully automated data update system, anticipating this tzdb release. Once I've got some settings tweaked, I can fix it up over the weekend. Then for all future data updates, it's a single press of a button to build a PR.

tmkx commented 7 months ago

@gilmoreorless thanks for your work and friendly note

m-urukov commented 7 months ago

@gilmoreorless Thanks you! We are really looking forward to the release of 2024a ❤️

Flightfreak commented 7 months ago

@gilmoreorless understood. A containerised solution and a GitHub workflow? Anyway, sounds like a good step forward!

gilmoreorless commented 7 months ago

A containerised solution and a GitHub workflow?

Pretty much! https://github.com/moment/moment-timezone/blob/6c31d29936a39207be6420e82e9f2bf2f231c6da/.github/workflows/build-data.yml

Managed to get it working after some false starts: https://github.com/moment/moment-timezone/pull/1095

gilmoreorless commented 7 months ago

Data 2024a is now available in release 0.5.45.