reset to defaultZone - Githubissues

gronke commented 8 months ago

Allow resetting to defaultZone by calling tz(null).

linux-foundation-easycla[bot] commented 8 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: gronke / name: Stefan Grönke (6746102da4ab50e8c76a6778dfacded30d415ccf)

gilmoreorless commented 8 months ago

Hi, thanks for your contribution. Unfortunately this PR won't be accepted into the project, for a few reasons:

This is technically a breaking API change. Right now, any falsey value passed into .tz() is treated the same as not providing an argument. This includes false, undefined, null, '' and 0. (I'm not saying this is an ideal API, just the reality of the situation.) This PR would change the behaviour of just one of those cases, unexpectedly.
The project is in maintenance mode, and the contributing guidelines explicitly say "new features or API changes are unlikely to be accepted as pull requests."
The new code is adding very modern ES syntax into an ES5 codebase that has no transpilation step.
There's a fairly simple workaround for resetting a instance's zone, if you know that there is a default zone set up: instance.tz(moment.defaultZone.name)

moment / moment-timezone