search

moment / moment-timezone

Timezone support for moment.js
momentjs.com/timezone
MIT License
3.82k stars 835 forks source link

Update 2024a.json #1098

Closed wiserweb closed 6 months ago

wiserweb commented 7 months ago

Removed Phoenix, Puerto_Rico, Panama which are not located in Canada and do not function as timezones for the country's zone.

linux-foundation-easycla[bot] commented 7 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

gilmoreorless commented 6 months ago

Hi, thanks for your contribution, but I'm going to close this PR for two reasons:

  1. The data files are auto-generated from the IANA tzdb releases. Any manual changes like this will be overwritten the next time a tzdb release happens. (Additionally, most installations of Moment Timezone read from a duplicate latest file that hasn't been altered in this PR.)
  2. I know it's confusing and not obvious, but the data file is correct for what it's intended to track. The short version is "it's not saying that all these zones are definitely in Canada, just that time in Canada can be represented by these zones". The longer version is https://github.com/moment/moment-timezone/issues/1066#issuecomment-1574578959