Closed NightTsarina closed 2 years ago
@NightTsarina thank you for this patch. From my understanding the tests are auto-generated from the tz-data, so it shouldn't be necessary to manually fix them. However they fail, so the truth is out there.
I'll try to sort out the tzdata generation and release a version using something more recent (like 2022c, or at least 2022a).
There's an open PR to use 2022b (which has the same zone data as 2022c): #996
There's an open PR to use 2022b (which has the same zone data as 2022c): https://github.com/moment/moment-timezone/pull/996
I appreciate the effort, but given that the data update is a pretty automated process (well it has a few shortcoming, I'm fixing them now), it makes more sense for somebody from the team to release, otherwise I have to run it anyway and check for correctness, I can't read and verify several thousand line patch by hand (and obviously I don't trust anybody :)). There should be a new release later today with 2022c
. I'll try to set reminder/notification for future updates.
@gilmoreorless hey, I see you're helping out with the issues. Do you want to become part of the team, moment-timezone can use some TLC (or at least a release once or twice a year :)).
@NightTsarina country tests now pass, I had to fix them by hand, because more was needed (than your patches). I guess becuase I changed something in the pipeline...
I see you're helping out with the issues. Do you want to become part of the team, moment-timezone can use some TLC
@ichernev I'm open to that. 😃 I'll ping you separately to avoid noise on this issue.
There's an open PR to use 2022b (which has the same zone data as 2022c): #996
I appreciate the effort, but given that the data update is a pretty automated process (well it has a few shortcoming, I'm fixing them now), it makes more sense for somebody from the team to release, otherwise I have to run it anyway and check for correctness, I can't read and verify several thousand line patch by hand (and obviously I don't trust anybody :)). There should be a new release later today with
2022c
. I'll try to set reminder/notification for future updates.
No worries, I sent this just in case it was useful.
I imagined there was some automated process, but I suppose I could not make it work when I started working on the Debian package.. Currently, it always uses the installed Olson DB when compiling the package, so if you could share the recipe to regenerate those tests, it would save me lots of work down the line!
@NightTsarina country tests now pass, I had to fix them by hand, because more was needed (than your patches). I guess becuase I changed something in the pipeline...
That's surprising.. they are passing here (when applied sequentially), but maybe there is some diff in the database?
@NightTsarina hopefully running grunt data
or grunt data:2022c
should work for you now, It generates tests (if you pass a version the tests go in temp, but you can execute them via node_modules/.bin/nodeunit temp/2022c/tests/**/*.js
or sth. Country tests are NOT generated, so I had to fix them by hand. I'm thinking of dropping them altogether, I mean what is the point if they will be only fixed by person to match the data... they should be either generated or not existing at all...
@NightTsarina hopefully running
grunt data
orgrunt data:2022c
should work for you now, It generates tests (if you pass a version the tests go in temp, but you can execute them vianode_modules/.bin/nodeunit temp/2022c/tests/**/*.js
or sth. Country tests are NOT generated, so I had to fix them by hand. I'm thinking of dropping them altogether, I mean what is the point if they will be only fixed by person to match the data... they should be either generated or not existing at all...
Right, that is what I thought :) I have been fixing them by hand for each Olson DB release for a while
Hi, as Debian maintainer of this package, I have been manually patching the unittests to follow changes in the Olson database.
Here are the two currently applied patches against the last release of moment-timezone.