search

momentohq / client-sdk-javascript

Official JavaScript SDK for Momento Serverless Cache
Apache License 2.0
55 stars 20 forks source link

fix: switch to a jest reporter that shows correct error counts, avoid network calls in unit tests #1414

Closed cprice404 closed 1 month ago

cprice404 commented 1 month ago

This commit just does a few housekeeping things.

  1. Switch from jest-ci-spec-reporter to jest-spec-reporter. They are similar, and neither of them is perfect, and neither of them has hardly any stars on github, but the jest-spec-reporter one prints the correct error counts at the end of the run. The jest-ci-spec-reporter one does not. (They both have the desired trait of using an output format that prints success/failure results for each test case on a single line, which makes it easier for operators to diagnose issues.
  2. Unit tests should not make network calls. Our cache client unit tests were doing so. This changes them to prevent them from doing that.
cprice404 commented 1 month ago

@anitarua I will take a swing at updating the notion runbook to reflect this, and ping you to sanity check me if that's okay