search

momentohq / client-sdk-javascript

Official JavaScript SDK for Momento Serverless Cache
Apache License 2.0
55 stars 20 forks source link

chore: replacing more 'instanceof's in examples with 'switch' #1423

Closed cprice404 closed 3 weeks ago

rishtigupta commented 3 weeks ago

lgtm!

One question (nit): I noticed some places where we have access to logger but we are still using console.log/console.info where we can use logger.info?

cprice404 commented 3 weeks ago

lgtm!

One question (nit): I noticed some places where we have access to logger but we are still using console.log/console.info where we can use logger.info?

hrm, good call. looks like that is always in those ensureCacheExists functions? Or did you see it somewhere else? I can fix those.