search

momentohq / client-sdk-php

Official PHP SDK for Momento Serverless Cache
Apache License 2.0
12 stars 6 forks source link

feat: add getBatch and setBatch #177

Closed rishtigupta closed 8 months ago

rishtigupta commented 9 months ago

PR Description:

References:

Design Doc (Notion)

cprice404 commented 9 months ago

Why are there a bunch of files like TopicPermission deleted from this PR?

rishtigupta commented 9 months ago

Why are there a bunch of files like TopicPermission deleted from this PR?

I had to recreate the protos from the client-types-php to get the latest protos in the sdk.

cprice404 commented 9 months ago

Why are there a bunch of files like TopicPermission deleted from this PR?

I had to recreate the protos from the client-types-php to get the latest protos in the sdk.

That's fine, but I wouldn't have expected those files to get deleted entirely... did they get moved to a different path or something? I would expect stuff like TopicPermission to still exist in the generated code?