momentohq / momento-cli

Official CLI for Momento Serverless Cache
Apache License 2.0
48 stars 10 forks source link

fix: speed up cloud linter command #306

Closed bruuuuuuuce closed 6 months ago

bruuuuuuuce commented 6 months ago

This command just speeds up the elasticache/getMetrics api calls. We need to refactor a bit how the limiter is working. We should be able to query DescribeDynamodbTables at a higher rate that we query the DescribeTimeToLive api. I spent a bit of time trying to configure separate rate limiters for the ddb api calls, but it was not behaving as expected. I think we might need to first describe all of the ddb tables, maybe have some heuristics around which tables are worth attempting to get a ttl off of, and then call those with a separate slower rate limiter

Before

Screen Shot 2024-04-10 at 6 15 17 PM

After image

bruuuuuuuce commented 6 months ago

I'm working on adding a heuristic around querying the time to live metric, which will supersede this pr

bruuuuuuuce commented 6 months ago

closing in favor of https://github.com/momentohq/momento-cli/pull/307