momentoscope / hextof-processor

Code for preprocessing data from the HEXTOF instrument at FLASH, DESY in Hamburg (DE)
https://hextof-processor.readthedocs.io/en/latest/
GNU General Public License v3.0
7 stars 4 forks source link

Make repo independent + new name? #18

Closed balerion closed 6 years ago

balerion commented 6 years ago

Currently this repo is a fork of Yves' repo. I suspect this means the idea would be to eventually merge the two with a pull request. Somehow, I think we should consider keeping the two completely separated, so that we might have Yves' repo as a legacy reference.

I am not sure I understand the consequences entirely, so if I am just asking for trouble, please let me know.

In any case, if we decide to act in this direction, it is possible to contact github to let them know we want to make this repo independent, and it should be a straightforward process.

RealPolitiX commented 6 years ago

It's a necessary move at some point. This won't affect Yves' original repo since you don't have the master-level rights to delete it

balerion commented 6 years ago

No, but should all the authors be happy with the switch to normal mode? In particular, is Yves happy with the switch?

RealPolitiX commented 6 years ago

I propose to change the name to hextof or hextofprocessor instead, easier to write To simplify packaging, the package name should be the same as the main folder of the code (in this case the processor folder). One can rename processor or merge that with the XPSdoniachs at a higher folder level.

balerion commented 6 years ago

The name change makes sense. I can also remove XPSdoniachs and put it on my repo, maybe just leave a link in the readme if it makes things easier

steinnymir commented 6 years ago

I agree with making this independent of Yves original repo, and also changing its name.

I will wait for Yves to confirm if he is ok with this, (Davide wrote him) and if we hear nothing till the end of the week I will proceed with the separation anyway next Monday.

Concerning name, I think hextof-processor is the most appropriate name, and the easiest to read and to write (no camel case, - instead of _. This appears to be the most common standard on github) but I am also ok with other options.

Also this can be done already, so I would proceed as soon as I get some positive feedback.

RealPolitiX commented 6 years ago

hextof-processor sounds fine with me. When I built the documentation, I only referenced the files in the processor folder, so there will be no conflict in the separation process.

RealPolitiX commented 6 years ago

@balerion if you are actively using the XPSdoniachs folder, why not just keep it there. It's good to have an example of how that is used.

balerion commented 6 years ago

So everyone involved has approved shifting to normal mode. @steinnymir would you take care of this please?

steinnymir commented 6 years ago

I will do this next monday.

balerion commented 6 years ago

awesome! thanks

steinnymir commented 6 years ago

Request sent, waiting for a response from GitHub

steinnymir commented 6 years ago

repo is now independent and name has changed to hextof-processor as discussed.