momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

fix for update issue in Combobox input #1369

Closed aigoel closed 2 years ago

aigoel commented 2 years ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Base: 94.02% // Head: 94.33% // Increases project coverage by +0.30% :tada:

Coverage data is based on head (1b8a4f6) compared to base (b73c360). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1369 +/- ## ========================================== + Coverage 94.02% 94.33% +0.30% ========================================== Files 132 132 Lines 18176 18181 +5 Branches 2769 2769 ========================================== + Hits 17090 17151 +61 + Misses 1086 1030 -56 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/combobox/ComboBox.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1369/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.16% <100.00%> (+<0.01%)` | :arrow_up: | | [web-components/src/components/list/ListItem.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1369/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbGlzdC9MaXN0SXRlbS50cw==) | `97.05% <0.00%> (-2.95%)` | :arrow_down: | | [web-components/src/components/avatar/Avatar.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1369/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYXZhdGFyL0F2YXRhci50cw==) | `94.28% <0.00%> (-1.91%)` | :arrow_down: | | [web-components/src/mixins/ResizeMixin.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1369/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL21peGlucy9SZXNpemVNaXhpbi50cw==) | `88.73% <0.00%> (-1.41%)` | :arrow_down: | | [web-components/src/components/menu/MenuItem.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1369/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbWVudS9NZW51SXRlbS50cw==) | `97.50% <0.00%> (-1.25%)` | :arrow_down: | | [web-components/src/components/tooltip/Tooltip.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1369/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdG9vbHRpcC9Ub29sdGlwLnRz) | `87.61% <0.00%> (-0.48%)` | :arrow_down: | | [web-components/src/components/icon/Icon.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1369/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaWNvbi9JY29uLnRz) | `82.73% <0.00%> (+4.16%)` | :arrow_up: | | [web-components/src/components/button/Button.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1369/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYnV0dG9uL0J1dHRvbi50cw==) | `98.61% <0.00%> (+16.66%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.