momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

Removed focus from chevron icon and added action on space bar key press #1409

Closed Samreen26 closed 1 year ago

Samreen26 commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.27% // Head: 94.24% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (2559d35) compared to base (6c11e71). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1409 +/- ## ========================================== - Coverage 94.27% 94.24% -0.03% ========================================== Files 132 132 Lines 18204 18207 +3 Branches 2775 2781 +6 ========================================== - Hits 17162 17160 -2 - Misses 1042 1047 +5 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/combobox/ComboBox.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.18% <100.00%> (+<0.01%)` | :arrow_up: | | [...mponents/src/components/draggable/DraggableItem.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZHJhZ2dhYmxlL0RyYWdnYWJsZUl0ZW0udHM=) | `93.75% <0.00%> (-6.25%)` | :arrow_down: | | [web-components/src/components/tabs/Tab.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGFicy9UYWIudHM=) | `94.60% <0.00%> (-5.40%)` | :arrow_down: | | [web-components/src/components/radio/Radio.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvcmFkaW8vUmFkaW8udHM=) | `95.69% <0.00%> (-2.16%)` | :arrow_down: | | [web-components/src/mixins/ResizeMixin.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL21peGlucy9SZXNpemVNaXhpbi50cw==) | `88.73% <0.00%> (-1.41%)` | :arrow_down: | | [web-components/src/components/menu/MenuItem.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbWVudS9NZW51SXRlbS50cw==) | `97.50% <0.00%> (-1.25%)` | :arrow_down: | | [web-components/src/components/tooltip/Tooltip.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdG9vbHRpcC9Ub29sdGlwLnRz) | `88.09% <0.00%> (+0.47%)` | :arrow_up: | | [web-components/src/components/theme/Theme.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGhlbWUvVGhlbWUudHM=) | `89.01% <0.00%> (+1.73%)` | :arrow_up: | | [web-components/src/components/label/Label.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbGFiZWwvTGFiZWwudHM=) | `100.00% <0.00%> (+2.22%)` | :arrow_up: | | [web-components/src/components/icon/Icon.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaWNvbi9JY29uLnRz) | `82.73% <0.00%> (+4.16%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.