momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-9184 : Accessibility issues in new UX for EP/Address Book #1410

Closed rituparnadey1807 closed 1 year ago

rituparnadey1807 commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

rituparnadey1807 commented 1 year ago

BUILD

rituparnadey1807 commented 1 year ago

BUILD

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.33% // Head: 93.88% // Decreases project coverage by -0.45% :warning:

Coverage data is based on head (af9f609) compared to base (700d626). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1410 +/- ## ========================================== - Coverage 94.33% 93.88% -0.45% ========================================== Files 132 132 Lines 18207 18210 +3 Branches 2782 2767 -15 ========================================== - Hits 17175 17097 -78 - Misses 1032 1113 +81 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/tabs/Tabs.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGFicy9UYWJzLnRz) | `88.35% <100.00%> (-0.09%)` | :arrow_down: | | [web-components/src/mixins/FocusTrapMixin.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL21peGlucy9Gb2N1c1RyYXBNaXhpbi50cw==) | `98.45% <100.00%> (+<0.01%)` | :arrow_up: | | [web-components/src/components/button/Button.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYnV0dG9uL0J1dHRvbi50cw==) | `81.94% <0.00%> (-16.67%)` | :arrow_down: | | [...ponents/src/components/progress-bar/ProgressBar.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvcHJvZ3Jlc3MtYmFyL1Byb2dyZXNzQmFyLnRz) | `86.60% <0.00%> (-13.40%)` | :arrow_down: | | [...mponents/src/components/draggable/DraggableItem.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZHJhZ2dhYmxlL0RyYWdnYWJsZUl0ZW0udHM=) | `93.75% <0.00%> (-6.25%)` | :arrow_down: | | [...components/src/components/datepicker/DatePicker.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZGF0ZXBpY2tlci9EYXRlUGlja2VyLnRz) | `87.45% <0.00%> (-2.67%)` | :arrow_down: | | [web-components/src/components/icon/Icon.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaWNvbi9JY29uLnRz) | `81.54% <0.00%> (-1.20%)` | :arrow_down: | | [web-components/src/components/input/Input.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaW5wdXQvSW5wdXQudHM=) | `99.24% <0.00%> (+0.37%)` | :arrow_up: | | [web-components/src/components/radio/Radio.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvcmFkaW8vUmFkaW8udHM=) | `97.84% <0.00%> (+2.15%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/momentum-design/momentum-ui/pull/1410?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rituparnadey1807 commented 1 year ago

BUILD

rituparnadey1807 commented 1 year ago

BUILD

rituparnadey1807 commented 1 year ago

BUILD

rituparnadey1807 commented 1 year ago

BUILD

rituparnadey1807 commented 1 year ago

BUILD