momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

fix: Home Page: Search- All is always present when searching for any specific entity #1412

Closed parsoman closed 1 year ago

parsoman commented 1 year ago

Home Page: Search- All is always present when searching for any specific entity

Description

Searching or typing in input field is restricted in case of allow-select-all is true

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.96% // Head: 93.99% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (2b687cf) compared to base (dfa1afe). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1412 +/- ## ========================================== + Coverage 93.96% 93.99% +0.02% ========================================== Files 132 132 Lines 18210 18213 +3 Branches 2774 2776 +2 ========================================== + Hits 17111 17119 +8 + Misses 1099 1094 -5 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/combobox/ComboBox.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.18% <100.00%> (+<0.01%)` | :arrow_up: | | [web-components/src/components/label/Label.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbGFiZWwvTGFiZWwudHM=) | `97.77% <0.00%> (-2.23%)` | :arrow_down: | | [...eb-components/src/components/help-text/HelpText.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaGVscC10ZXh0L0hlbHBUZXh0LnRz) | `98.33% <0.00%> (-1.67%)` | :arrow_down: | | [web-components/src/mixins/RovingTabIndexMixin.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL21peGlucy9Sb3ZpbmdUYWJJbmRleE1peGluLnRz) | `97.27% <0.00%> (+3.63%)` | :arrow_up: | | [...mponents/src/components/draggable/DraggableItem.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZHJhZ2dhYmxlL0RyYWdnYWJsZUl0ZW0udHM=) | `100.00% <0.00%> (+6.25%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.