momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-9873 : Agent Desktop became unresponsive #1414

Closed yasagraw closed 1 year ago

yasagraw commented 1 year ago

Fixing multiple scroll while virtual scrolling

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.25% // Head: 93.97% // Decreases project coverage by -0.29% :warning:

Coverage data is based on head (4cc65bf) compared to base (cd9121c). Patch has no changes to coverable lines.

:exclamation: Current head 4cc65bf differs from pull request most recent head f7ea27f. Consider uploading reports for the commit f7ea27f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1414 +/- ## ========================================== - Coverage 94.25% 93.97% -0.29% ========================================== Files 132 132 Lines 18213 18213 Branches 2779 2771 -8 ========================================== - Hits 17167 17116 -51 - Misses 1046 1097 +51 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/button/Button.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYnV0dG9uL0J1dHRvbi50cw==) | `81.94% <0.00%> (-16.67%)` | :arrow_down: | | [web-components/src/components/list/ListItem.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbGlzdC9MaXN0SXRlbS50cw==) | `97.05% <0.00%> (-2.95%)` | :arrow_down: | | [web-components/src/components/radio/Radio.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvcmFkaW8vUmFkaW8udHM=) | `95.69% <0.00%> (-2.16%)` | :arrow_down: | | [web-components/src/components/icon/Icon.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaWNvbi9JY29uLnRz) | `81.54% <0.00%> (+1.78%)` | :arrow_up: | | [web-components/src/components/label/Label.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbGFiZWwvTGFiZWwudHM=) | `100.00% <0.00%> (+2.22%)` | :arrow_up: | | [web-components/src/mixins/RovingTabIndexMixin.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL21peGlucy9Sb3ZpbmdUYWJJbmRleE1peGluLnRz) | `97.27% <0.00%> (+3.63%)` | :arrow_up: | | [...mponents/src/components/draggable/DraggableItem.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZHJhZ2dhYmxlL0RyYWdnYWJsZUl0ZW0udHM=) | `100.00% <0.00%> (+6.25%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.