momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-9966: Accessibility issue fixes #1422

Closed aigoel closed 1 year ago

aigoel commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.81% // Head: 94.11% // Increases project coverage by +0.29% :tada:

Coverage data is based on head (0a04c61) compared to base (ffa3055). Patch coverage: 94.59% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1422 +/- ## ========================================== + Coverage 93.81% 94.11% +0.29% ========================================== Files 132 132 Lines 18247 18269 +22 Branches 2778 2799 +21 ========================================== + Hits 17119 17193 +74 + Misses 1128 1076 -52 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/combobox/ComboBox.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.72% <88.23%> (+0.19%)` | :arrow_up: | | [web-components/src/components/dropdown/Dropdown.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZHJvcGRvd24vRHJvcGRvd24udHM=) | `88.95% <100.00%> (+0.11%)` | :arrow_up: | | [...omponents/src/components/phone-input/PhoneInput.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvcGhvbmUtaW5wdXQvUGhvbmVJbnB1dC50cw==) | `98.00% <100.00%> (+0.01%)` | :arrow_up: | | [web-components/src/components/tooltip/Tooltip.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdG9vbHRpcC9Ub29sdGlwLnRz) | `90.90% <100.00%> (+2.81%)` | :arrow_up: | | [web-components/src/mixins/FocusTrapMixin.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL21peGlucy9Gb2N1c1RyYXBNaXhpbi50cw==) | `98.96% <100.00%> (+0.51%)` | :arrow_up: | | [web-components/src/components/label/Label.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbGFiZWwvTGFiZWwudHM=) | `97.77% <0.00%> (-2.23%)` | :arrow_down: | | [web-components/src/components/icon/Icon.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaWNvbi9JY29uLnRz) | `81.54% <0.00%> (-1.20%)` | :arrow_down: | | [...nts/src/components/table-advanced/TableAdvanced.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGFibGUtYWR2YW5jZWQvVGFibGVBZHZhbmNlZC50cw==) | `88.10% <0.00%> (+0.46%)` | :arrow_up: | | ... and [9 more](https://codecov.io/gh/momentum-design/momentum-ui/pull/1422?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.