momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-9987 : Multiple scroll fix in firefox #1424

Closed yasagraw closed 1 year ago

yasagraw commented 1 year ago

Firefox does not support has() selector therefore removing it

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.99% // Head: 93.89% // Decreases project coverage by -0.11% :warning:

Coverage data is based on head (0ea5306) compared to base (50fdff3). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1424 +/- ## ========================================== - Coverage 93.99% 93.89% -0.11% ========================================== Files 132 132 Lines 18234 18236 +2 Branches 2784 2782 -2 ========================================== - Hits 17139 17122 -17 - Misses 1095 1114 +19 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/combobox/ComboBox.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.52% <100.00%> (+<0.01%)` | :arrow_up: | | [web-components/src/components/tabs/Tab.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGFicy9UYWIudHM=) | `94.60% <0.00%> (-5.40%)` | :arrow_down: | | [web-components/src/components/icon/Icon.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaWNvbi9JY29uLnRz) | `79.76% <0.00%> (-1.79%)` | :arrow_down: | | [...nts/src/components/table-advanced/TableAdvanced.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGFibGUtYWR2YW5jZWQvVGFibGVBZHZhbmNlZC50cw==) | `87.64% <0.00%> (-0.47%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.