momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

Menu overlay Component : Prevent Keydown event if slot-element is md-input field #1425

Closed rathnavel closed 1 year ago

rathnavel commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.02% // Head: 93.88% // Decreases project coverage by -0.14% :warning:

Coverage data is based on head (98fb392) compared to base (b73c360). Patch coverage: 95.38% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1425 +/- ## ========================================== - Coverage 94.02% 93.88% -0.14% ========================================== Files 132 132 Lines 18176 18247 +71 Branches 2769 2780 +11 ========================================== + Hits 17090 17132 +42 - Misses 1086 1115 +29 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/button/Button.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYnV0dG9uL0J1dHRvbi50cw==) | `81.94% <66.66%> (ø)` | | | [web-components/src/components/tabs/Tabs.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGFicy9UYWJzLnRz) | `87.77% <81.81%> (-0.67%)` | :arrow_down: | | [...nts/src/components/floating-modal/FloatingModal.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZmxvYXRpbmctbW9kYWwvRmxvYXRpbmdNb2RhbC50cw==) | `81.81% <85.71%> (-0.41%)` | :arrow_down: | | [web-components/src/components/combobox/ComboBox.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.52% <100.00%> (+0.37%)` | :arrow_up: | | [...ponents/src/components/menu-overlay/MenuOverlay.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbWVudS1vdmVybGF5L01lbnVPdmVybGF5LnRz) | `96.41% <100.00%> (+0.10%)` | :arrow_up: | | [web-components/src/components/modal/Modal.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbW9kYWwvTW9kYWwudHM=) | `93.97% <100.00%> (+1.24%)` | :arrow_up: | | [web-components/src/components/radio/RadioGroup.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvcmFkaW8vUmFkaW9Hcm91cC50cw==) | `100.00% <100.00%> (ø)` | | | [web-components/src/components/taskitem/TaskItem.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGFza2l0ZW0vVGFza0l0ZW0udHM=) | `100.00% <100.00%> (ø)` | | | [web-components/src/components/theme/Theme.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGhlbWUvVGhlbWUudHM=) | `89.01% <100.00%> (+0.12%)` | :arrow_up: | | [web-components/src/components/tooltip/Tooltip.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdG9vbHRpcC9Ub29sdGlwLnRz) | `88.09% <100.00%> (ø)` | | | ... and [14 more](https://codecov.io/gh/momentum-design/momentum-ui/pull/1425?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.