momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

md-combobox : Not getting the "combobox-input" callback event when the input value is empty #1426

Closed Samreen26 closed 1 year ago

Samreen26 commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.03% // Head: 94.31% // Increases project coverage by +0.28% :tada:

Coverage data is based on head (85ce9cc) compared to base (e18f7e2). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1426 +/- ## ========================================== + Coverage 94.03% 94.31% +0.28% ========================================== Files 132 132 Lines 18269 18273 +4 Branches 2792 2800 +8 ========================================== + Hits 17179 17235 +56 + Misses 1090 1038 -52 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/combobox/ComboBox.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.72% <100.00%> (+<0.01%)` | :arrow_up: | | [web-components/src/components/theme/Theme.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGhlbWUvVGhlbWUudHM=) | `87.28% <0.00%> (-1.74%)` | :arrow_down: | | [...eb-components/src/components/help-text/HelpText.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaGVscC10ZXh0L0hlbHBUZXh0LnRz) | `98.33% <0.00%> (-1.67%)` | :arrow_down: | | [web-components/src/mixins/ResizeMixin.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL21peGlucy9SZXNpemVNaXhpbi50cw==) | `88.73% <0.00%> (-1.41%)` | :arrow_down: | | [web-components/src/components/input/Input.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaW5wdXQvSW5wdXQudHM=) | `98.87% <0.00%> (-0.38%)` | :arrow_down: | | [web-components/src/components/tooltip/Tooltip.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdG9vbHRpcC9Ub29sdGlwLnRz) | `90.90% <0.00%> (+0.45%)` | :arrow_up: | | [web-components/src/components/icon/Icon.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaWNvbi9JY29uLnRz) | `82.73% <0.00%> (+1.19%)` | :arrow_up: | | [web-components/src/components/button/Button.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYnV0dG9uL0J1dHRvbi50cw==) | `98.61% <0.00%> (+16.66%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.