momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

feat(icons): 🎸 new-manager logo is added #1429

Open vishnupcisco opened 1 year ago

vishnupcisco commented 1 year ago

Description

The new-manager logo is added to show the "Sub Partners" icon in the Control Hub Sidebar menu

Related Issue

https://jira-eng-gpk2.cisco.com/jira/browse/CALL-83030

Motivation and Context

I have to add the Sub Partner menu in the Control Hub sidebar, so I am adding this logo as part of it.

How Has This Been Tested?

Screenshots:

Screenshot 2023-02-22 at 12 25 03 AM

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.10% // Head: 94.12% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (e55243e) compared to base (502808a). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1429 +/- ## ========================================== + Coverage 94.10% 94.12% +0.02% ========================================== Files 132 132 Lines 18273 18273 Branches 2798 2797 -1 ========================================== + Hits 17196 17200 +4 + Misses 1077 1073 -4 ``` | [Impacted Files](https://codecov.io/gh/momentum-design/momentum-ui/pull/1429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/icon/Icon.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaWNvbi9JY29uLnRz) | `82.73% <0.00%> (+1.19%)` | :arrow_up: | | [web-components/src/components/label/Label.ts](https://codecov.io/gh/momentum-design/momentum-ui/pull/1429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbGFiZWwvTGFiZWwudHM=) | `100.00% <0.00%> (+2.22%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

vldmoraru commented 1 year ago

@ArthusLiang can you please take a look? UX is requesting to use these icons from @momentum-ui/icons-rebrand on Webex CH, but we don't plan to add the rebranded icons yet. Thank you!

vishnupcisco commented 1 year ago

@vldmoraru Thanks for the review. Actually, I need to have the same icon in 16x16 size but I don't see it in the @momentum-ui/icons-rebrand. What I added here is 32x32 svg. Could you check this as well?

vldmoraru commented 1 year ago

@vishnupcisco looks like this is the icon that you need https://github.com/momentum-design/momentum-ui/blob/master/icons-rebrand/svg/new-manager-bold.svg

vldmoraru commented 1 year ago

Let's wait on this one a bit; we are trying to negotiate with UX to use an already existing icon in the deprecated package.

vishnupcisco commented 1 year ago

Let's wait on this one a bit; we are trying to negotiate with UX to use an already existing icon in the deprecated package.

Changing into Draft PR