Open vishnupcisco opened 1 year ago
Base: 94.10% // Head: 94.12% // Increases project coverage by +0.02%
:tada:
Coverage data is based on head (
e55243e
) compared to base (502808a
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ArthusLiang can you please take a look? UX is requesting to use these icons from @momentum-ui/icons-rebrand
on Webex CH, but we don't plan to add the rebranded icons yet. Thank you!
@vldmoraru Thanks for the review. Actually, I need to have the same icon in 16x16 size but I don't see it in the @momentum-ui/icons-rebrand
. What I added here is 32x32 svg. Could you check this as well?
@vishnupcisco looks like this is the icon that you need https://github.com/momentum-design/momentum-ui/blob/master/icons-rebrand/svg/new-manager-bold.svg
Let's wait on this one a bit; we are trying to negotiate with UX to use an already existing icon in the deprecated package.
Let's wait on this one a bit; we are trying to negotiate with UX to use an already existing icon in the deprecated package.
Changing into Draft PR
Description
The
new-manager
logo is added to show the "Sub Partners" icon in the Control Hub Sidebar menuRelated Issue
https://jira-eng-gpk2.cisco.com/jira/browse/CALL-83030
Motivation and Context
I have to add the Sub Partner menu in the Control Hub sidebar, so I am adding this logo as part of it.
How Has This Been Tested?
Screenshots:
Types of changes
Checklist: