momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

Add Icons file for Webex Portrait Mode feature #1437

Closed parkerhz closed 1 year ago

parkerhz commented 1 year ago

Add the file for the Portrait feature. https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-326727 This PR add three Icons.

With three icons in this path, desktop client team can

  1. use the the generate_momentum_qrc.py to delete the fill color
  2. add into momentum.qrc
  3. then create PR into spark-client-framework

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (8cf2b98) 94.00% compared to head (e7835d4) 93.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1437 +/- ## ========================================== - Coverage 94.00% 93.98% -0.03% ========================================== Files 132 132 Lines 18279 18279 Branches 2787 2795 +8 ========================================== - Hits 17183 17179 -4 - Misses 1096 1100 +4 ``` [see 9 files with indirect coverage changes](https://codecov.io/gh/momentum-design/momentum-ui/pull/1437/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.