momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-11306 : Navigation of cursor in combobox propagates to tab above #1447

Closed arsyam1 closed 1 year ago

arsyam1 commented 1 year ago

CX-11306

Description

Added onKeyDown.ArrowLeft and onKeyDown.ArrowRight for Combobox.ts

Related Issue

https://jira-eng-sjc12.cisco.com/jira/browse/CX-11306

Motivation and Context

In the Outdial Popover the cursor navigation of the using the left/right arrow keys propagates to the md-Tabs above

How Has This Been Tested?

Manually tested

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.24 :warning:

Comparison is base (140769e) 94.39% compared to head (c059d4d) 94.16%.

:exclamation: Current head c059d4d differs from pull request most recent head 92875e1. Consider uploading reports for the commit 92875e1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1447 +/- ## ========================================== - Coverage 94.39% 94.16% -0.24% ========================================== Files 132 132 Lines 18316 18322 +6 Branches 2824 2818 -6 ========================================== - Hits 17289 17252 -37 - Misses 1027 1070 +43 ``` | [Impacted Files](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/combobox/ComboBox.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.50% <33.33%> (-0.24%)` | :arrow_down: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1447/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.