Open shammy8 opened 1 year ago
Patch coverage has no change and project coverage change: -0.20
:warning:
Comparison is base (
80e95f9
) 94.00% compared to head (4b10633
) 93.81%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Description
Sass-loader has deprecated the use of tilde for awhile now: https://github.com/webpack-contrib/sass-loader#resolving-import-at-rules
Angular 15 has totally stopped supporting tilde as well: https://github.com/angular/angular-cli/issues/25266#issuecomment-1562820118
This PR removes the tilde from scss files in the core and icons packages.
I have left a couple of tildes in for example the ones in the core/app and core/templates folder as these one doesn't seem to affect us. I'm guessing since they get compiled to something else before being consumed by the end user.
(edit) looks like just removing the ~ doesn't work as it can't compile the app in core/app. I have changed it to use relative paths instead.
Related Issue
https://github.com/momentum-design/momentum-ui/issues/1453
Motivation and Context
Allows the library to be used with Angular 15+ projects
How Has This Been Tested?
Types of changes
Checklist: