momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

feat: add buffering state to audio player component #1461

Closed zachraymer closed 1 year ago

zachraymer commented 1 year ago

The audio player component now has a timeline indicator to show what range is buffered

Description

A separate gray indicator has been added to the timeline (progress bar) of the audio component to indicate which portion of it has been buffered

Related Issue

https://jira-eng-sjc12.cisco.com/jira/browse/CX-11617

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

https://github.com/momentum-design/momentum-ui/assets/20385642/c142713e-e85b-44b1-9dc8-ac0f411b8ab8

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 94.73% and project coverage change: -0.40 :warning:

Comparison is base (e1d6afb) 94.25% compared to head (73c3ab1) 93.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1461 +/- ## ========================================== - Coverage 94.25% 93.85% -0.40% ========================================== Files 134 134 Lines 18765 18783 +18 Branches 2872 2848 -24 ========================================== - Hits 17687 17629 -58 - Misses 1078 1154 +76 ``` | [Impacted Files](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1461?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [...ponents/src/components/audio-player/AudioPlayer.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1461?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYXVkaW8tcGxheWVyL0F1ZGlvUGxheWVyLnRz) | `94.18% <94.73%> (+0.01%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1461/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.