momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-11790 : Adding role=alert for md-banner-alert #1464

Closed yasagraw closed 1 year ago

yasagraw commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.33 :warning:

Comparison is base (5749483) 94.38% compared to head (dc5a7a2) 94.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1464 +/- ## ========================================== - Coverage 94.38% 94.05% -0.33% ========================================== Files 134 134 Lines 18804 18804 Branches 2874 2864 -10 ========================================== - Hits 17749 17687 -62 - Misses 1055 1117 +62 ``` | [Impacted Files](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [...ponents/src/components/alert-banner/AlertBanner.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYWxlcnQtYmFubmVyL0FsZXJ0QmFubmVyLnRz) | `100.00% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1464/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.