momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-11806 : alert screen reader fix for desktop notification #1465

Closed binduN closed 1 year ago

binduN commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17 :tada:

Comparison is base (a788a8d) 93.86% compared to head (2ea10d2) 94.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1465 +/- ## ========================================== + Coverage 93.86% 94.03% +0.17% ========================================== Files 134 134 Lines 18804 18804 Branches 2859 2863 +4 ========================================== + Hits 17651 17683 +32 + Misses 1153 1121 -32 ``` | [Impacted Files](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/alert/Alert.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYWxlcnQvQWxlcnQudHM=) | `96.29% <100.00%> (ø)` | | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1465/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

binduN commented 1 year ago

changes pushed as part of https://github.com/momentum-design/momentum-ui/pull/1464/files