momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-11353 : Memory issue Fix #1466

Closed yasagraw closed 1 year ago

yasagraw commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% :tada:

Comparison is base (a510dc0) 93.97% compared to head (97b1160) 94.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1466 +/- ## ========================================== + Coverage 93.97% 94.00% +0.03% ========================================== Files 134 134 Lines 18804 18815 +11 Branches 2861 2864 +3 ========================================== + Hits 17671 17687 +16 + Misses 1133 1128 -5 ``` | [Files Changed](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/mixins/FocusTrapMixin.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL21peGlucy9Gb2N1c1RyYXBNaXhpbi50cw==) | `98.99% <100.00%> (+0.02%)` | :arrow_up: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1466/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.