momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-11353 : Memory issue Fix #1467

Closed yasagraw closed 1 year ago

yasagraw commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% :tada:

Comparison is base (a510dc0) 93.97% compared to head (1af0023) 94.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1467 +/- ## ========================================== + Coverage 93.97% 94.07% +0.10% ========================================== Files 134 134 Lines 18804 18814 +10 Branches 2861 2865 +4 ========================================== + Hits 17671 17700 +29 + Misses 1133 1114 -19 ``` | [Files Changed](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/mixins/FocusTrapMixin.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL21peGlucy9Gb2N1c1RyYXBNaXhpbi50cw==) | `98.99% <100.00%> (+0.02%)` | :arrow_up: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.