CX-12004 : Audio Player Speed Playback not keyboard navigable

cmullenx commented 1 year ago

Description

Audio Player component speed menu is now navigable via up and down keys

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 95.86% and project coverage change: +0.23% :tada:

Comparison is base (b73c360) 94.02% compared to head (60aadcc) 94.26%. Report is 113 commits behind head on master.

:exclamation: Current head 60aadcc differs from pull request most recent head 093ad93. Consider uploading reports for the commit 093ad93 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1469 +/- ## ========================================== + Coverage 94.02% 94.26% +0.23% ========================================== Files 132 134 +2 Lines 18176 18849 +673 Branches 2769 2878 +109 ========================================== + Hits 17090 17768 +678 + Misses 1086 1081 -5 ``` | [Files Changed](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/button/Button.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYnV0dG9uL0J1dHRvbi50cw==) | `98.07% <81.81%> (+16.13%)` | :arrow_up: | | [...nts/src/components/floating-modal/FloatingModal.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZmxvYXRpbmctbW9kYWwvRmxvYXRpbmdNb2RhbC50cw==) | `81.81% <85.71%> (-0.41%)` | :arrow_down: | | [web-components/src/components/tabs/Tabs.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGFicy9UYWJzLnRz) | `87.77% <85.71%> (-0.67%)` | :arrow_down: | | [...ponents/src/components/audio-player/AudioPlayer.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYXVkaW8tcGxheWVyL0F1ZGlvUGxheWVyLnRz) | `94.80% <94.80%> (ø)` | | | [web-components/src/components/combobox/ComboBox.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.74% <97.91%> (+0.58%)` | :arrow_up: | | [...ponents/src/components/alert-banner/AlertBanner.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYWxlcnQtYmFubmVyL0FsZXJ0QmFubmVyLnRz) | `100.00% <100.00%> (ø)` | | | [web-components/src/components/alert/Alert.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYWxlcnQvQWxlcnQudHM=) | `96.29% <100.00%> (ø)` | | | [...nents/src/components/audio-player/scss/module.scss](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYXVkaW8tcGxheWVyL3Njc3MvbW9kdWxlLnNjc3M=) | `100.00% <100.00%> (ø)` | | | [...ponents/src/components/chat-message/ChatMessage.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY2hhdC1tZXNzYWdlL0NoYXRNZXNzYWdlLnRz) | `100.00% <100.00%> (ø)` | | | [...rc/components/date-range-picker/DateRangePicker.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZGF0ZS1yYW5nZS1waWNrZXIvRGF0ZVJhbmdlUGlja2VyLnRz) | `100.00% <100.00%> (ø)` | | | ... and [18 more](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1469/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

parsoman commented 1 year ago

@cmullenx Can you increase the version in your PR?

cmullenx commented 1 year ago

@cmullenx Can you increase the version in your PR?

done

momentum-design / momentum-ui