momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-10233 : Global: Screen Readers: Resize Modal button is announced without sufficient context #1473

Closed yasagraw closed 9 months ago

yasagraw commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.32% :tada:

Comparison is base (c797780) 93.95% compared to head (95edfc7) 94.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1473 +/- ## ========================================== + Coverage 93.95% 94.28% +0.32% ========================================== Files 134 134 Lines 18849 18850 +1 Branches 2866 2882 +16 ========================================== + Hits 17709 17772 +63 + Misses 1140 1078 -62 ``` | [Files Changed](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [...nts/src/components/floating-modal/FloatingModal.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZmxvYXRpbmctbW9kYWwvRmxvYXRpbmdNb2RhbC50cw==) | `81.86% <100.00%> (+0.04%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1473/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.