momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-10475 : Incoming Email: Keyboard Navigation: Keyboard focus is trapped on the cancel button #1474

Closed aadesh4217 closed 1 year ago

aadesh4217 commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 95.91% and project coverage change: +0.31% :tada:

Comparison is base (b73c360) 94.02% compared to head (36b0e7e) 94.33%. Report is 116 commits behind head on master.

:exclamation: Current head 36b0e7e differs from pull request most recent head 7bb4861. Consider uploading reports for the commit 7bb4861 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1474 +/- ## ========================================== + Coverage 94.02% 94.33% +0.31% ========================================== Files 132 134 +2 Lines 18176 18856 +680 Branches 2769 2879 +110 ========================================== + Hits 17090 17788 +698 + Misses 1086 1068 -18 ``` | [Files Changed](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/button/Button.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYnV0dG9uL0J1dHRvbi50cw==) | `98.07% <81.81%> (+16.13%)` | :arrow_up: | | [...nts/src/components/floating-modal/FloatingModal.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZmxvYXRpbmctbW9kYWwvRmxvYXRpbmdNb2RhbC50cw==) | `81.81% <85.71%> (-0.41%)` | :arrow_down: | | [web-components/src/components/tabs/Tabs.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvdGFicy9UYWJzLnRz) | `87.77% <85.71%> (-0.67%)` | :arrow_down: | | [...ponents/src/components/audio-player/AudioPlayer.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYXVkaW8tcGxheWVyL0F1ZGlvUGxheWVyLnRz) | `94.80% <94.80%> (ø)` | | | [web-components/src/components/combobox/ComboBox.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY29tYm9ib3gvQ29tYm9Cb3gudHM=) | `97.74% <97.91%> (+0.58%)` | :arrow_up: | | [...ponents/src/components/alert-banner/AlertBanner.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYWxlcnQtYmFubmVyL0FsZXJ0QmFubmVyLnRz) | `100.00% <100.00%> (ø)` | | | [web-components/src/components/alert/Alert.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYWxlcnQvQWxlcnQudHM=) | `96.29% <100.00%> (ø)` | | | [...nents/src/components/audio-player/scss/module.scss](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvYXVkaW8tcGxheWVyL3Njc3MvbW9kdWxlLnNjc3M=) | `100.00% <100.00%> (ø)` | | | [...ponents/src/components/chat-message/ChatMessage.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvY2hhdC1tZXNzYWdlL0NoYXRNZXNzYWdlLnRz) | `100.00% <100.00%> (ø)` | | | [...rc/components/date-range-picker/DateRangePicker.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvZGF0ZS1yYW5nZS1waWNrZXIvRGF0ZVJhbmdlUGlja2VyLnRz) | `100.00% <100.00%> (ø)` | | | ... and [18 more](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1474/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.