momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-12280 : Adding Editable div to behave like input element #1483

Open prakhar-tiwari opened 1 year ago

prakhar-tiwari commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (ddf1ee3) 94.39% compared to head (f6b0afd) 93.97%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1483 +/- ## ========================================== - Coverage 94.39% 93.97% -0.42% ========================================== Files 134 134 Lines 18922 18970 +48 Branches 2890 2892 +2 ========================================== - Hits 17861 17827 -34 - Misses 1061 1143 +82 ``` | [Files](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [web-components/src/components/input/Input.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvaW5wdXQvSW5wdXQudHM=) | `92.61% <22.00%> (-6.27%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.