momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

#CX-12187 : Allow hover hover behavior to toggle menu overlay. #1491

Closed vikcool2pr closed 1 year ago

vikcool2pr commented 1 year ago

Description

Menu-overlay component allows toggling overlay on click by trigger element. Same behavior is implemented with hovering trigger element with this implementation.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (7373100) 94.39% compared to head (c57788e) 93.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1491 +/- ## ========================================== - Coverage 94.39% 93.96% -0.44% ========================================== Files 134 134 Lines 18926 18957 +31 Branches 2893 2886 -7 ========================================== - Hits 17865 17812 -53 - Misses 1061 1145 +84 ``` | [Files](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design) | Coverage Δ | | |---|---|---| | [...ponents/src/components/menu-overlay/MenuOverlay.ts](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design#diff-d2ViLWNvbXBvbmVudHMvc3JjL2NvbXBvbmVudHMvbWVudS1vdmVybGF5L01lbnVPdmVybGF5LnRz) | `96.66% <100.00%> (+0.26%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/momentum-design/momentum-ui/pull/1491/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=momentum-design)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.