#CX-12361 : Added tabindex and arialabel in badge component

momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.

https://momentum.design

MIT License

199 stars 204 forks source link

#CX-12361 : Added tabindex and arialabel in badge component #1506

Closed yasagraw closed 10 months ago

yasagraw commented 10 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (515e139) 94.26% compared to head (c0a979f) 94.14%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1506 +/- ## ========================================== - Coverage 94.26% 94.14% -0.12% ========================================== Files 134 134 Lines 18987 18988 +1 Branches 2913 2904 -9 ========================================== - Hits 17898 17877 -21 - Misses 1089 1111 +22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.