momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

CX-10233 : Screen Readers: Resize Modal button is announced without sufficient context #1530

Closed iruchipriya closed 8 months ago

iruchipriya commented 8 months ago

Description

Story - CX-10233 Prerequisites:

  1. Tab to reach the Webex button and press enter to activate it.
  2. Tab to reach the resize modal button and observe the announcement when it is full-screen mode and half-screen mode. Expected Result: The resize Modal button should be announced with sufficient context i.e. When the model is in halfscreen mode, it should announce as 'Halfscreen Resize Modal' and when the model is in fullscreen mode, it should announce as 'Fullscreen Resize Modal' or similar. Actual Result: The 'Resize Modal' button is announced without sufficient context. i.e.
    • the 'Resize Modal' button announces the same label for both the half-screen and full-screen mode and the screen reader user will not know the state of the control as 'Resize Modal, button'

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

Checklist:

Issue screenshot - image

Video Link For Issue - https://platform.applause.com/services/links/v1/external/e418790303d083cd604a5701204ac017906e12812bec60a519e8b183979279e9

Screenshot after Fix -

image image

VidCast Link - https://app.vidcast.io/share/d5f69e35-c744-4a5b-9c72-f25d5f7fb263

vinitkumargoel commented 8 months ago

@iruchipriya You need to update momentum version also

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (140824c) 94.13% compared to head (7301d4b) 94.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1530 +/- ## ========================================== + Coverage 94.13% 94.22% +0.08% ========================================== Files 134 134 Lines 18991 18992 +1 Branches 2903 2911 +8 ========================================== + Hits 17878 17896 +18 + Misses 1113 1096 -17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.