search

momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

Accessibility fix: [CX-13319] updated role for menu overlay component #1533

Closed niti-owner closed 8 months ago

niti-owner commented 8 months ago

Accessibility fix for menu-overlay component

Description

Updated the role type to "menu" from "tooltip" for the menu overlay component

Related Issue

https://jira-eng-sjc12.cisco.com/jira/browse/CX-13319

Motivation and Context

Referred : https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles ARIA: menu role The menu role is a type of composite widget that offers a list of choices to the user.

Screen Recording of before and after fix: https://github.com/momentum-design/momentum-ui/assets/41052645/7c7eeec1-aab1-45b0-89df-e71b0bd97ad0

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (db58151) 94.22% compared to head (310cf78) 94.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1533 +/- ## ========================================== - Coverage 94.22% 94.17% -0.06% ========================================== Files 134 134 Lines 18988 18988 Branches 2908 2905 -3 ========================================== - Hits 17892 17881 -11 - Misses 1096 1107 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.