search

momentum-design / momentum-ui

Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.
https://momentum.design
MIT License
199 stars 204 forks source link

fix (accessibility): updated tab panel id to be unique #1536

Closed niti-owner closed 8 months ago

niti-owner commented 8 months ago

Description

Updated Tab panel id to be unique and not same as tab id

Related Issue

Story: https://jira-eng-sjc12.cisco.com/jira/browse/CX-10177

Screenshots:

Before : Screenshot 2024-02-13 at 12 38 11 PM

Screenshot 2024-02-13 at 12 42 06 PM

After: Screenshot 2024-02-13 at 12 37 05 PM

Screenshot 2024-02-13 at 12 41 35 PM

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (db58151) 94.22% compared to head (04dee5d) 94.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1536 +/- ## ======================================= Coverage 94.22% 94.22% ======================================= Files 134 134 Lines 18988 18990 +2 Branches 2908 2910 +2 ======================================= + Hits 17892 17894 +2 Misses 1096 1096 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.